unleash-client-dotnet icon indicating copy to clipboard operation
unleash-client-dotnet copied to clipboard

adjusted UnleashService so that feature toggles can loaded immediatel…

Open realityenigma opened this issue 6 years ago • 3 comments

adjusted UnleashService so that feature toggles can loaded immediately via LoadTogglesImmediately setting.

realityenigma avatar Jun 29 '18 15:06 realityenigma

So the Cake powershell script builds these updates successfully and Visual Studio Build as well. Not sure what's going on with Appveyor.

realityenigma avatar Jun 29 '18 15:06 realityenigma

Sorry man, I have been away from my computer a few weeks now.

There should already be an implemented feature doing "almost" what you want, but in an async manner using (FetchFeatureTogglesTask with ExecuteDuringStartup = true). This uses Timers behind the scenes, which are executed immediately. Are you experiencing a noticeable gap during startup where no toggles are loaded?

Regarding the pull request, doing an async method call in a constructor plus dot Result feels a bit wrong to me.. Perhaps a dedicated async method on DefaultUnleash class could be a better option?

stiano avatar Jul 21 '18 16:07 stiano

@realityenigma take a peek on https://github.com/stiano/unleash-client-dotnet/pull/14/files#diff-180360612c6b8c4ed830919bbb4dd459, this solved my issue with appvoyer (currently having others)

silviogreuel avatar Oct 02 '19 01:10 silviogreuel