stianhoiland
Regression: Can't switch between windows of same app after some time
Eventually Alt-Tilde/Backquote seems to stop working. "Eventually" as in after cmdtab has run for some time. Probably something goes wrong after cmdtab has observed more than 128 window changes, which is max history entries. The code that handles the overflow is here. Admittedly I wrote this while rather exhausted, so I won't be surprised if it's wonky.
I can't repro. However, you generate an off-by-one in the linked code.
In the if branch, postfix incrementation should be used
sizeof History[0] * HistoryCount++
and in the else branch take either
sizeof History[0] * (HistoryCount - 1)
or, preferably something like
sizeof History[0] * (countof(History) - 1) or sizeof History - sizeof History[0]
to tell the compiler it's a constant expression which doesn't need to be calculated at runtime.
I'll refrain from further PRs for now as it doesn't seem you have time to review them at the moment.
