Broken using node 12

Open No9 opened this issue 5 years ago • 2 comments

I just tried running this against v12.6.1 and there are a number of issues. @mmarchini I noticed on your repo you had started looking at n-api https://github.com/mmarchini/node-usdt/tree/n-api. Do you have a view on which way it should go? i.e. Stick with NaN and or move to n-api? Would appreciate getting your perspective on it :)

Apr 05 '20 22:04 No9

We should move to N-API. I haven't worked in this lib for a while though, but I guess it should be easy enough to migrate. What's your use case?

Apr 06 '20 02:04 mmarchini

Thanks for the pointer I'm looking at diagnostic user journeys in a kubernetes environment.

Apr 06 '20 09:04 No9