stgeke

We need to declare all functions using a new `INCLUDE` file or add them to existing ones.

Is the input to AMGX_matrix_upload_distributed() assumed to be assembled?

1

To be more precise: Does it add to values on other processors?

Incomplete CMake config

4

Important options are missing * HIP * Umpire * enable-device-malloc-async * enable-gpu-aware-mpi * ...

Multi-physics simulations often involve running multiple codes coupled together while some of them may use a different HYPRE version or configuration. This will only work as expected if there are...

Add runtime switch to run on CPU or GPU

7

At the moment this seems to be a compile time switch.

Example: ``` const auto a = device.malloc( ); myKernel(..., a); @kernel void myKernel(..., float *a) { ... } Currently it is not recognized that the kernel modifies a const memory...

It's quite error prone. Example: If the kernel argument is e.g. `float` one need to pass `0.f` instead of simply `0`. In other words the data type has to match...

Example: ``` occa::memory foo(Nentries); ```