PSyclone (Closes #2138) add support for expressions in array bound definitions

Jul 01 '24 10:07 arporter

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (9a94641) to head (b9fd5e1).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2637   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         352      352           
  Lines       48485    48507   +22     
=======================================
+ Hits        48420    48442   +22     
  Misses         65       65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jul 01 '24 12:07 codecov[bot]

Integration tests failed due to attempt to call walk on an Extent at line 293 of sympy_writer.py.

Jul 01 '24 13:07 arporter

The latest NEMO code ends up with some pretty hairy array indexing and declarations due to the tiling. I've added an example to one of the tests. Integration tests are re-running (it was only the NEMO ones that failed).

Jul 01 '24 16:07 arporter

Integration tests were green second time around. I just need to address missing coverage.

Jul 02 '24 07:07 arporter

Ready for review now. A fairly small change but ensuring that it worked when handling the declaration of members of a structure was quite difficult. One for @LonelyCat124, @hiker or @sergisiso.

Jul 02 '24 09:07 arporter

There was an indirect coverage change, hence the new test. Ready for another look now.

Jul 09 '24 07:07 arporter