PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

#1351 - Support for user-defined kernels that operate on DoFs

Open oakleybrunt opened this issue 1 year ago • 2 comments

Closes #1351

oakleybrunt avatar Apr 23 '24 12:04 oakleybrunt

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (91119cd) to head (abd9101).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2556   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         357      357           
  Lines       48339    48339           
=======================================
  Hits        48273    48273           
  Misses         66       66           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 25 '24 14:04 codecov[bot]

Thanks for this Oakley. I think you've mostly got the top-level rules sorted but you're missing a section on the rules for the kernel subroutine itself - see inline. Note I've brought the branch up to master so you'll need to pull before you make changes.

Hey Andy, thanks for your comments. I completely overlooked this, ha! You're right, the subroutine rules will be quite simple. I've added them now so I'll re-request a review.

oakleybrunt avatar May 10 '24 14:05 oakleybrunt