PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

(Closes #1832) add support for force option to ParallelLoopTrans

Open arporter opened this issue 3 years ago • 2 comments

Functionally, this is a small PR that just adds a 'force' option to ParallelLoopTrans. However, I've also take the opportunity to improve the testing of this class.

arporter avatar Oct 21 '22 11:10 arporter

Codecov Report

Base: 99.83% // Head: 99.84% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (1020510) compared to base (cacca74). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 1020510 differs from pull request most recent head 192e5ec. Consider uploading reports for the commit 192e5ec to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1925    +/-   ##
========================================
  Coverage   99.83%   99.84%            
========================================
  Files         302      301     -1     
  Lines       41840    41659   -181     
========================================
- Hits        41773    41594   -179     
+ Misses         67       65     -2     
Impacted Files Coverage Δ
src/psyclone/core/component_indices.py 100.00% <ø> (ø)
...clone/psyir/transformations/parallel_loop_trans.py 100.00% <100.00%> (ø)
src/psyclone/transformations.py 99.36% <100.00%> (-0.02%) :arrow_down:
src/psyclone/dynamo0p3.py 99.88% <0.00%> (-0.01%) :arrow_down:
src/psyclone/nemo.py 100.00% <0.00%> (ø)
src/psyclone/psyir/transformations/__init__.py 100.00% <0.00%> (ø)
...psyclone/psyir/transformations/acc_update_trans.py
src/psyclone/gocean1p0.py 99.86% <0.00%> (+<0.01%) :arrow_up:
src/psyclone/psyir/nodes/acc_directives.py 100.00% <0.00%> (+0.36%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 21 '22 11:10 codecov[bot]

Note that I'm not sure how best to document this new option. It's in the class docstring but it's a virtual class that is then sub-classed by several different transformations. Adding it to the docstring of each of those doesn't feel like the right thing to do but I'm open to suggestions.

Ready for review from @sergisiso, @rupertford or @hiker .

arporter avatar Oct 21 '22 14:10 arporter

Ready for another look now.

arporter avatar Dec 15 '22 16:12 arporter