PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

(Closes #1909) update to latest master of fparser

Open arporter opened this issue 3 years ago • 2 comments

The latest fparser has additional symbol table functionality and support for some additional Fortran2008 features (particularly the mold argument to allocate).

arporter avatar Oct 11 '22 13:10 arporter

Codecov Report

Base: 99.83% // Head: 99.83% // No change to project coverage :thumbsup:

Coverage data is based on head (495af8c) compared to base (9905b77). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1911   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         285      285           
  Lines       40867    40867           
=======================================
  Hits        40801    40801           
  Misses         66       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 11 '22 14:10 codecov[bot]

I've discovered that fparser2 doesn't work when two optional parameters are supplied to allocate() since the match reverts to the F2003 one. Therefore I'm pausing this PR while I fix that (https://github.com/stfc/fparser/issues/298).

arporter avatar Oct 11 '22 14:10 arporter

CI permitting this is ready for review. It just updates the fparser submodule and changes the GHA yml to make sure that the CI uses that version of fparser rather than a released version.

arporter avatar Nov 16 '22 14:11 arporter