PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

Complete parsing of LFRic Kernel metadata (closes 1879)

Open rupertford opened this issue 3 years ago • 1 comments

This PR extends the existing LFRic Kernel metadata support to include the remaining metadata, such as gh_shape and meta_funcs.

rupertford avatar Oct 10 '22 14:10 rupertford

Codecov Report

Base: 99.83% // Head: 99.84% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (66c9bed) compared to base (6b5aa91). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1908    +/-   ##
========================================
  Coverage   99.83%   99.84%            
========================================
  Files         285      299    +14     
  Lines       40867    41346   +479     
========================================
+ Hits        40801    41280   +479     
  Misses         66       66            
Impacted Files Coverage Δ
src/psyclone/domain/lfric/kernel/__init__.py 100.00% <100.00%> (ø)
...n/lfric/kernel/columnwise_operator_arg_metadata.py 100.00% <100.00%> (ø)
...syclone/domain/lfric/kernel/common_arg_metadata.py 100.00% <100.00%> (ø)
...domain/lfric/kernel/common_declaration_metadata.py 100.00% <100.00%> (ø)
...ne/domain/lfric/kernel/common_meta_arg_metadata.py 100.00% <100.00%> (ø)
...rc/psyclone/domain/lfric/kernel/common_metadata.py 100.00% <100.00%> (ø)
.../domain/lfric/kernel/evaluator_targets_metadata.py 100.00% <100.00%> (ø)
...psyclone/domain/lfric/kernel/field_arg_metadata.py 100.00% <100.00%> (ø)
...e/domain/lfric/kernel/field_vector_arg_metadata.py 100.00% <100.00%> (ø)
...one/domain/lfric/kernel/inter_grid_arg_metadata.py 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 11 '22 11:10 codecov[bot]

OK, I think this is ready for first review from @arporter. It's a biggy I'm afraid. The implementation still needs constraint checking between classes but that can wait for a future PR.

rupertford avatar Nov 02 '22 23:11 rupertford

OK, this is ready for its next review from @arporter

rupertford avatar Nov 10 '22 16:11 rupertford

Ready for next review from @arporter.

rupertford avatar Nov 16 '22 22:11 rupertford

Ready for next review from @arporter

rupertford avatar Nov 23 '22 12:11 rupertford