PSyclone
PSyclone copied to clipboard
Fix assorted docstrings
In addition to these small typos I found while revising #1554, I also noticed that the example we give for ACCEnterDataTrans wouldn't actually add the directive by lack of a kernels/parallel construct in the schedule. Is this what we intended?
Codecov Report
Base: 99.51% // Head: 99.51% // No change to project coverage :thumbsup:
Coverage data is based on head (
2918cb4
) compared to base (07d62f6
). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #1846 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 269 269
Lines 39380 39380
=======================================
Hits 39188 39188
Misses 192 192
Impacted Files | Coverage Δ | |
---|---|---|
src/psyclone/psyir/nodes/node.py | 97.33% <ø> (ø) |
|
src/psyclone/transformations.py | 99.29% <ø> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I also noticed that the example we give for ACCEnterDataTrans wouldn't actually add the directive by lack of a kernels/parallel construct in the schedule. Is this what we intended?
Oops, no! Would you mind fixing it in this PR?
Should we change SOURCE_FILE
to, say, GOCEAN_SOURCE_FILE
and start using, say, NEMO_SOURCE_FILE
instead of tra_adv.F90
directly?
Should we change
SOURCE_FILE
to, say,GOCEAN_SOURCE_FILE
and start using, say,NEMO_SOURCE_FILE
instead oftra_adv.F90
directly?
Yes, that's a good idea.
Should we change
SOURCE_FILE
to, say,GOCEAN_SOURCE_FILE
and start using, say,NEMO_SOURCE_FILE
instead oftra_adv.F90
directly?Yes, that's a good idea.
Done. This whole PR was a bit harder than I thought it'd be!