PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

1813 standalone extract

Open hiker opened this issue 2 years ago • 2 comments

This is the stand-alone extraction library. Note that I have not added compilation tests (which we can do) to keep the patch smaller.

hiker avatar Aug 22 '22 07:08 hiker

Codecov Report

Base: 99.51% // Head: 99.51% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (3d215e6) compared to base (14e7ce3). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   99.51%   99.51%   -0.01%     
==========================================
  Files         269      269              
  Lines       39380    39379       -1     
==========================================
- Hits        39188    39187       -1     
  Misses        192      192              
Impacted Files Coverage Δ
...c/psyclone/domain/common/extract_driver_creator.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 22 '22 07:08 codecov[bot]

This is ready for a first review, but ideally would be done after merging #1831 (which will likely cause some clashes).

Note that the link checking will fail because the links to the standalone library, which I have added, do not exist yet.

hiker avatar Aug 24 '22 08:08 hiker

I believe the link check is caused by the stand-alone directory missing, which this PR will add. And I don't understand the coverage issue at all (I believe I might have removed one covered line, which might slightly reduce the percentage of covered lines??)

hiker avatar Sep 05 '22 04:09 hiker

OK, I hope I've fixed all incorrect references to NetCDF. The link-check errors are expected since they point to paths that do not yet exist on master. The coverage issue should just be a hiccup (i.e. removed covered lines --> percentage of covered lines decreases). Ready for first review.

hiker avatar Sep 06 '22 05:09 hiker