PSyclone
PSyclone copied to clipboard
(closes #1823) Fix ModuleInline issues in LFric
These are:
- [x] Prevent generating repeated copies of the same routines
- [ ] Bring kernel global module imports to the Invoke file
Codecov Report
Base: 99.51% // Head: 99.51% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
ff6dadc
) compared to base (8073187
). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #1844 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 268 268
Lines 39312 39347 +35
=======================================
+ Hits 39120 39155 +35
Misses 192 192
Impacted Files | Coverage Δ | |
---|---|---|
src/psyclone/dynamo0p3.py | 99.85% <100.00%> (+<0.01%) |
:arrow_up: |
src/psyclone/psyGen.py | 98.41% <100.00%> (-0.01%) |
:arrow_down: |
src/psyclone/tests/dynamo0p3_test.py | 100.00% <100.00%> (ø) |
|
src/psyclone/tests/psyGen_test.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@arporter @rupertford This is ready for review. I decided to just fix one of the issues (prevent duplicated routines when inlining from different invokes if the routine is an exact match) and rename this to a "towards" PR.
@rupertford This is ready for another review.