PSyclone
PSyclone copied to clipboard
Outdated tutorials
Some tutorials appear to be outdated. In at least one case the solution file was fixed, but not the file the user is supposed to modify. Example:
psyclone/tutorial/practicals/LFRic/building_code/3_time_evolution$ diff prop_perturbation_kernel_mod.f90 solutions/prop_perturbation_kernel_mod.f90
...
< use argument_mod, only: arg_type, func_type, &
< GH_FIELD, GH_REAL, &
< GH_WRITE, GH_READ, &
< CELLS
---
> use argument_mod, only: arg_type, func_type, &
> GH_FIELD, GH_REAL, &
> GH_SCALAR, &
> GH_READWRITE, GH_READ, &
> CELL_COLUMN
67,70c68,71
< type(arg_type), dimension(3) :: meta_args = (/ &
< arg_type(GH_FIELD, GH_WRITE, W3), &
< arg_type(GH_FIELD*3, GH_READ, W3), &
< arg_type(GH_REAL, GH_READ) &
---
> type(arg_type), dimension(3) :: meta_args = (/ &
> arg_type(GH_FIELD, GH_REAL, GH_READWRITE, W3), &
> arg_type(GH_FIELD*3, GH_REAL, GH_READ, W3), &
> arg_type(GH_SCALAR, GH_REAL, GH_READ) &
72c73
< integer :: iterates_over = CELLS
---
> integer :: operates_on = CELL_COLUMN
Is that done on purpose (i.e. part of the training??) If not, should I open a ticket?
<https://teams.microsoft.com/l/message/19:[email protected]/1660032682496?tenantId=3f66361c-a87e-4158-8f61-99e82db3cac8&groupId=38f4ed55-5f70-4478-b992-835e4011118a&parentMessageId=1660032682496&teamName=PSyclone&channelName=Developers&createdTime=1660032682496>