PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

(closes #1828) Fixes to enable explicit OpenACC Loop parallelism with UM

Open sergisiso opened this issue 1 year ago • 3 comments

sergisiso avatar Aug 09 '22 08:08 sergisiso

Codecov Report

Base: 99.51% // Head: 99.51% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (c6d7dd8) compared to base (83ed707). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
- Coverage   99.51%   99.51%   -0.01%     
==========================================
  Files         264      264              
  Lines       39214    39212       -2     
==========================================
- Hits        39022    39020       -2     
  Misses        192      192              
Impacted Files Coverage Δ
src/psyclone/psyir/nodes/acc_directives.py 100.00% <100.00%> (ø)
src/psyclone/tests/alggen_test.py 100.00% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_basis_test.py 99.02% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_cma_test.py 100.00% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_haloex_test.py 100.00% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_lma_test.py 100.00% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_multigrid_test.py 100.00% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_quadrature_test.py 100.00% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_stubgen_test.py 100.00% <100.00%> (ø)
src/psyclone/tests/dynamo0p3_test.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 09 '22 08:08 codecov[bot]

This is ready for review. Probably one for @arporter

sergisiso avatar Aug 11 '22 14:08 sergisiso

@hiker I brought it to master and fixed some additional pylint and pycodestyle issues. This is ready for next review.

sergisiso avatar Aug 30 '22 09:08 sergisiso

I've took the liberty to disable two more pylint warnings and bringing this up to current master. AS soon as CI is finished, I'll merge it.

hiker avatar Sep 05 '22 02:09 hiker

I believe the failed coverage is caused by removing covered lines (--> fraction of uncovered lines slightly increases), all changes here appear to be fine. I'll merge this now.

hiker avatar Sep 05 '22 02:09 hiker