PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

(Close #1815) Prevent OMPTargetDirectives with Codeblocks

Open sergisiso opened this issue 2 years ago • 3 comments

I implemented the validation in both: the transformation and the node global validation. I have not tackled the ACCKernelDirective constraints, see https://github.com/stfc/PSyclone/issues/1815#issuecomment-1199430014 but happy to add it if needed.

sergisiso avatar Jul 29 '22 14:07 sergisiso

Codecov Report

Base: 99.51% // Head: 99.51% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (1c725ae) compared to base (e864331). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1819   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         263      264    +1     
  Lines       39203    39214   +11     
=======================================
+ Hits        39011    39022   +11     
  Misses        192      192           
Impacted Files Coverage Δ
src/psyclone/psyir/transformations/region_trans.py 100.00% <ø> (ø)
src/psyclone/transformations.py 99.29% <ø> (-0.01%) :arrow_down:
src/psyclone/psyir/nodes/omp_directives.py 99.77% <100.00%> (+<0.01%) :arrow_up:
src/psyclone/psyir/transformations/__init__.py 100.00% <100.00%> (ø)
...psyclone/psyir/transformations/omp_target_trans.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 29 '22 15:07 codecov[bot]

@arporter This is ready for review. It is a relatively small PR to close #1815 . I could also use the PR to move the OMPTargetTrans to src/psyclone/psyir/transformations if you want (the tests were already in this path), but I have not moved it for the first review to make the changes clear.

sergisiso avatar Jul 29 '22 15:07 sergisiso

@arporter I reduced the scope of this PR to just remove codeblocks (original issue) and move the transformation locations.

The UBOUND and LBOUND issues are a compiler bug that only happens under specific conditions, so I will deal with it on the optimization script.

This is ready for another review.

sergisiso avatar Aug 31 '22 08:08 sergisiso

@arporter This is ready for next review

sergisiso avatar Sep 01 '22 10:09 sergisiso