PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

Initial inlining support (towards #924)

Open arporter opened this issue 1 year ago • 4 comments

arporter avatar Jul 26 '22 08:07 arporter

Codecov Report

Base: 99.50% // Head: 99.51% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (67648a1) compared to base (136ec52). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1814    +/-   ##
========================================
  Coverage   99.50%   99.51%            
========================================
  Files         262      263     +1     
  Lines       39054    39203   +149     
========================================
+ Hits        38862    39011   +149     
  Misses        192      192            
Impacted Files Coverage Δ
src/psyclone/psyir/symbols/datatypes.py 100.00% <100.00%> (ø)
src/psyclone/psyir/transformations/__init__.py 100.00% <100.00%> (ø)
src/psyclone/psyir/transformations/inline_trans.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 26 '22 08:07 codecov[bot]

This is ready for first review now. One for @rupertford or @sergisiso.

arporter avatar Jul 26 '22 19:07 arporter

Note that in doing this I had to extend ScalarType with a __eq__ method. I've added associated tests for that. This may touch on what @LonelyCat124 has been doing recently.

arporter avatar Aug 18 '22 09:08 arporter

Ready for next review from @sergisiso now.

arporter avatar Aug 18 '22 09:08 arporter

Assuming CI happiness, this is ready for another look now.

arporter avatar Sep 01 '22 10:09 arporter