PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

Published 20 hours ago • verified publisher icon stfc

[Otter] Update interface with Otter to reflect upstream changes

Open adamtuft opened this issue 2 years ago • 3 comments

This PR is for review by @LonelyCat124

This PR updates the interface to Otter to reflect the latest changes to Otter in v0.2.0. These changes include:

  • Renaming several Otter API entrypoints,
  • Changing the arguments passed to several entrypoints,
  • Removing the otterTaskSingle[Begin|End] entrypoint which no longer exists.

adamtuft avatar Jun 29 '22 15:06 adamtuft

@arporter @sergisiso Is there a way to override the testing system to work on PRs that don't involve master?

LonelyCat124 avatar Jul 21 '22 12:07 LonelyCat124

You can add "[skip ci]" to the commit message if that's what you're after?

arporter avatar Jul 21 '22 17:07 arporter

The opposite, I want ci to run on this branch before I merge it into my branch. I can do it manually if needed but was hoping it could be done here.

LonelyCat124 avatar Jul 21 '22 18:07 LonelyCat124

With all the changes to Otter I think we're going to try to swap to using PSyData to do the otter profiling. I'm going to leave this PR open for now while we work on that but this will be closed later

LonelyCat124 avatar Jan 05 '24 12:01 LonelyCat124