PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

Sum2CodeTrans transformation (closes 1711)

Open rupertford opened this issue 2 years ago • 2 comments

rupertford avatar Jun 23 '22 12:06 rupertford

Codecov Report

Base: 99.51% // Head: 99.51% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (7046ee6) compared to base (6cc2ced). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1768    +/-   ##
========================================
  Coverage   99.51%   99.51%            
========================================
  Files         269      270     +1     
  Lines       39411    39534   +123     
========================================
+ Hits        39219    39342   +123     
  Misses        192      192            
Impacted Files Coverage Δ
src/psyclone/psyir/transformations/__init__.py 100.00% <100.00%> (ø)
.../transformations/intrinsics/operator2code_trans.py 100.00% <100.00%> (ø)
...psyir/transformations/intrinsics/sum2code_trans.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 11 '22 16:08 codecov[bot]

Ready for first review. Probably one for @sergisiso but I am sure @arporter would also do a fine job.

It's mostly there but may be a little rough around the edges. Want to bet on whether it works for NEMO out of the box?

rupertford avatar Aug 12 '22 23:08 rupertford

I've added the transformation to the user guide and it builds fine for me.

rupertford avatar Sep 07 '22 19:09 rupertford

Ready for next review from @sergisiso.

rupertford avatar Sep 07 '22 20:09 rupertford

Ready for next review from @sergisiso

rupertford avatar Sep 20 '22 13:09 rupertford