THREE.VRController icon indicating copy to clipboard operation
THREE.VRController copied to clipboard

THREE.VRController.onGamepadDisconnect needs to be called when contro…

Open lehoangphu opened this issue 6 years ago • 2 comments

…llers are removed.

The flow of the bug goes like this: . When the controller is connected, the gamepad object is saved at this.controller[x] . then when the controller is disconnected, the saved this.controller[x] is still in your array but the object is gone (all null) . then when the controller is reconnected again, it see that both gamepads[x] and this.controller[x] are both non-null so it does not update, then goes on to consume this.controller[x] which is already stale.

This change makes sure that we flush out the this.controllers array correctly.

lehoangphu avatar Sep 11 '18 22:09 lehoangphu

This fixes our exact problem. Please merge!

codefrau avatar Oct 05 '18 06:10 codefrau

@stewdio , can you merge this one?

lehoangphu avatar Oct 11 '18 22:10 lehoangphu