Stephen Day

There are a few ways to do this but the easiest is to have a type with pointers to each possible request type. This works kind of like a union....

@mcollina > Folks, libchan in its form is both a spec and an implementation, and it > should be designed to be implementable in other platform. Strings works > cross-platform....

@mcollina It's rather unfortunate that msgpack5 chose to include a 'NULL' type in the protocol. Formats like protobuf, gob and thrift gain a lot of efficiency by not transmitting null,...

Regarding the following `Request` structure: ``` type Request struct { Cmd string Data *msgpack.RawMessage Ret libchan.Sender } ``` Let's say we have a message F, with an `io.Reader`, along with...

#30 now has `Read` return io.EOF. when `len(Rread.Data) == 0`, but doesn't handle a short read correctly, which is a requirement of `io.ReaderAt`.

@simonferquel We actually need to maintain `io.ReaderAt` semantics, since `Session.Read` takes an offset. I am not sure the effect of returning short reads from `io.ReaderAt` without an error.

We can return an error when the buffer is partially read. I omitted it in #30 because it would require a little bit of gymnastics to make the truncated request...

@simonferquel Not really: the difference is that there is a separate object managing the negotiation. The channel itself is actually a product of the negotiation.

@joushou Could you send a PR that makes this fix?

For the most part, this was written to be fatal on any kind of error, so I am not sure what specifically you want changed. A few questions: Where in...