Stephen Day

Results 291 comments of Stephen Day

@m-masataka There are several commits that are not signed. I'd recommend sqaushing them all into a single commit.

@m-masataka No, please make this PR into a single commit.

@AndreaGiardini Looking at it closely. The biggest blocker is testing. Have you tried out these changes?

@porterjamesj @dlorenc 9ps is just a simple pass-through to test the sessionization a forwarding. Please see https://github.com/docker/go-p9p/blob/master/cmd/9ps/main.go#L67. You can run it with another tool, called ufs, to test it out....

@aaron-prindle You can just use any existing 9p server. `ufs` was apart of the original go9p bindings, found in https://code.google.com/archive/p/go9p/source/default/source. If someone wants to submit a PR that makes 9ps...

> Seems like it's just mac OS/Docker for Mac related I don't think either of these test paths are machine specific, so this is a bit of a surprise. Would...

@joushou Can you reproduce this with 9pr/9ps or was this with another implementation?

@joushou I'll take a peak when I get some time. These are mostly just toys for demonstrating use of the package, but I can see them becoming a diagnostic tool...

While technically idiomatic, there are cases where you'd return something in the case of an error. Here, I don't think that would be validate. To users of the package, I...

@alimoeeny We generally vendor everything, so I am not worried about broken builds. It seems like maintaining backwards compatibility should be mostly possible, except for the broken timeout configuration options...