steveseguin
Update circle.js
added set interval checking based off zoom.js code which appears to be working in tests
Thank you for this pull request.
I'm not entirely sure this is needed. the last Message variable doesn't exist either, so it doesn't appear to be doing anything.
I took a look and the circle.js script already is looking for page loads and checks at an interval already, so I'd imagine it should be working.
window.addEventListener('popstate', checkUrlAndRunScript);
setInterval(function(){
try {
if (!checkUrlAndRunScript()){return;}
if (document.querySelector('#message-scroll-view')){
Looking at the manifest code, the code will only inject if one of the following pages is loaded:
It won't load the script if you "soft navigate" to one of those pages though, so perhaps keep an eye out there.
You're the expert and I will absolutely defer to you, but all I know from limited testing is adding in that code and going live allowed me to get comments for the first time without having to reset.
I ran three tests to confirm it.
One with myself from my mobile device but then realize since maybe I was a host in two locations that might have changed something?
And 2 with my wife as a viewer and for the first time comments came up on the first try.
One error in the console log:
[image: Screenshot 2024-11-01 at 12.26.56 PM.png]
And we had one instance where a comment showed in the chat but did not show in the Social Stream monitor window.
We experience that maybe 1 out of every 15-20 comments during our live broadcasts and not sure what might be the cause of that.
Put yourself FIRST with First In Nutrition!
Jonathan - Co Founder of First In
Check out First In Nutrition on YouTube for tips, tricks, and tactics to start putting yourself FIRST at @.***!
On Fri, Nov 1, 2024 at 4:00 PM Steve Seguin @.***> wrote:
Thank you for this pull request.
I'm not entirely sure this is needed. the last Message variable doesn't exist either, so it doesn't appear to be doing anything.
I took a look and the circle.js script already is looking for page loads and checks at an interval already, so I'd imagine it should be working.
window.addEventListener('popstate', checkUrlAndRunScript);
setInterval(function(){ try { if (!checkUrlAndRunScript()){return;} if (document.querySelector('#message-scroll-view')){
Looking at the manifest code, the code will only inject if one of the following pages is loaded:
image.png (view on web) https://github.com/user-attachments/assets/dceb1cb8-eefe-44d6-af84-e4ab56ac6622
It won't load the script if you "soft navigate" to one of those pages though, so perhaps keep an eye out there.
— Reply to this email directly, view it on GitHub https://github.com/steveseguin/social_stream/pull/309#issuecomment-2452508119, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLCVOEJL72IJMSESYQV2HADZ6PMXFAVCNFSM6AAAAABRASWMNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSGUYDQMJRHE . You are receiving this because you authored the thread.Message ID: @.***>