node-jira icon indicating copy to clipboard operation
node-jira copied to clipboard

Auth passing for request should not be in the URI

Open wetnun opened this issue 12 years ago • 1 comments

By putting the user/pass into the URI you limit people to uncomplicated passwords. For example if my password was 'iL@vePa#s' it turns into 'https://user:iL@vePa%23s@host:443' which is obviously broken. request allows you to pass in the authentication information.

One possible solution for this is to create a function to generate the options and you just pass in overrides. That way you can avoid fixing all of the hard coded hashes you currently have in place in the future when you want to make changes.

Since we use complicated passwords I'm probably going to have to work on this anyways. So if I get it working I'll do a pull request.

wetnun avatar Oct 02 '13 19:10 wetnun

Resolved with #44

fabiomoscariello avatar Jun 01 '24 19:06 fabiomoscariello