Steve Rhoades
Steve Rhoades
LOL! Didn't notice that but your right, I agree - consistency in that regard makes sense.
Hope you dont mind but I merged this PR into the libuv 1.0 WIP.
Very interested in this addition. Is there anything I can do to help get this across the finish line?
This would also apply to AssertionAggregate and AssertionInterface classes. In addition this would be a backwards compatibility break.
Here is the current benchmarks running 1538 rules. ``` Function Count Incl. Excl. Average (ms) Zend\Permissions\Acl\Acl::setRule() 1538 1,463.07 832.59 0.95 Zend\Permissions\Acl\Acl::getRules() 70450 319.49 292.49 0.00 Zend\Permissions\Acl\Acl::getResource() 70214 132.21 98.47 0.00...
@Ocramius good point. How about: ``` foreach($children as $key => $child) { $resources[$key] = $child; } ```
@Ocramius I should know better, I'll check out the tests. From reading the code it appears as though the keys should be resourceIds... perhaps i have that wrong.
@sestinj is there something that is blocking this from being merged, anything I can address? It'd be nice to get that sweet open file functionality in my instance of VSCode...
Just a heads up, I think i've discovered a much simpler approach to solve this issue without having to run the wslpath process. I'll be pushing the update here shortly.