Steve Repsher comments

Results 210 comments of


                                            Steve Repsher

fix(workbox-build): make source map filename consistent with injected source file

@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.

fix(workbox-build): make source map filename consistent with injected source file

> At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks! I know they passed locally when I first created the...

fix(workbox-build): make source map filename consistent with injected source file

The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.

fix(workbox-build): make source map filename consistent with injected source file

@tropicadri are you able to review and release this change? I'd like to avoid creating a patch if I can.

Document webpack change: feat: introduce a new syntax for worklets - `*context.audioWorklet.addModule()`

@alexander-akait I'm having to dig into the code to understand what exactly the new syntax will match. Could you add some documentation for this with some match / won't match...

Update brands URLs to use fallback search parameter

> @steverep Is this PR now ready for a follow-up? Or can we close it for now? I need to re-throw up the changes to the brands repo first. Should...

No break between heading and description in settings row

This is still an issue.

No break between heading and description in settings row

Still an issue

No break between heading and description in settings row

Still and issue

Many checkboxes have no labels for accessibility

As I'm paying more attention now, I'm realizing this is not just the analytics form. There are lots of checkboxes that need fixing. For example, all checkboxes on a user...