Steve Piercy
Steve Piercy
Shame on me. @jenstroeger I forgot to ask you to sign `CONTRIBUTORS.txt` in the other PR, but we can do that in this one.
A rebase on master or merging master into this branch should fix the CI.
This LGTM. I've requested a review from any maintainer so they can cut a release after approval and merge. Thank you! @mcdonc @ericof @miohtama @mmerickel @tseaver
Regarding `msg`, I think when more than one part of the data URL is not valid, then each invalid part should return its error message and that each message should...
> Actually, I think the current implementation is somewhat cumbersome because both MIME type and Base64 data will be handled _twice_ — first by the validator, and then again by...
I still don't follow the reason to do what you describe. I understand what you propose, but I do not understand why it is needed the second time. What does...
I'm not familiar with Cornice, so I don't know why it would do two passes on the same data. But from what I can tell on this line: https://github.com/Cornices/cornice/blob/15dfca94b7cc31e285f9290579399d5a57c6e07a/cornice/validators/_colander.py#L120 ...it...
> Yup 🤓 And now I’d like to get the data out of the validated URL: Yes, but _why_? Once you get it then decode it to bytes as in...
Ah, now I see. That makes sense. Is there any other type in Colander that returns the parts? I did not see one, so this would be a new feature....
> Which one is the “token” here? From https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs#syntax `[;base64]`