Steven Zeck

Results 77 comments of Steven Zeck

I think for the most part this is good. But a few things: 1. I'm still not 100% clear what the difference is between `PresentationProperties` and `PresentationSettings`. If that could...

Really need to take a hard look at this sooner than later...

Hi @armendh, this looks better now. As I mentioned in an earlier comment, this most likely would be merged right before or right after a Readium release. Just a few...

@armendh Sorry, can you make that same change in [ExoMediaPlayer](https://github.com/armendh/kotlin-toolkit/blob/3f273b573f159ad573d1735f2a57002245ec9c34/readium/navigator/src/main/java/org/readium/r2/navigator/media/ExoMediaPlayer.kt#L95)? `C.AUDIO_CONTENT_TYPE_MUSIC`

The three `Bundle` extensions should also be deprecated, all of which are also in `Intent.kt`. They are used the OPDS feeds to pass the Publication [from](https://github.com/readium/kotlin-toolkit/blob/72991f7b11333513c00ba3bc504fde27ce4d6e9f/test-app/src/main/java/org/readium/r2/testapp/catalogs/PublicationAdapter.kt#L59-L61) the list to the...

Yeah ideally we don't want to pass around those large objects in Intents/Bundles, plus Compose doesn't support that anyways. But the OPDS feed implementation is limited to the testapp, and...

Yeah, something changed with the nanohttpd repository. The current workaround, suggested in Slack, is using the below block in your root `build.gradle.kts` file (adjust if using groovy). ``` allprojects {...

@danielweck I think the epub in the kotlin-toolkit issue has the issue directly in the `` tag. So this may require a more extensive long-term fix. I looked through a...

Hi @ekilmer, I like this idea. I don't think we would ever build images from dev branches, but tagging via `latest` and `major.minor.patch` would be helpful in the long term....

@cdfa are you using the CLI, VSCode plugin or just calling it via Node?