bxslider-4 icon indicating copy to clipboard operation
bxslider-4 copied to clipboard

Links inside the sliders are not working on Chrome

Open elymentree opened this issue 5 years ago • 18 comments

Works well on other major browsers.

elymentree avatar Mar 29 '19 20:03 elymentree

Agreed, i've just updated to version chrome v73. Links or click events no longer work on chrome

jenbhu avatar Apr 01 '19 10:04 jenbhu

Quickfix: You can set touchEnabled: false and only set this option mobile to true.

EDIT: The error is in line 1085: slider.viewport.on('touchstart MSPointerDown pointerdown', onTouchStart); Pointerdown prevents clicking when there is linked text in the slider. So far I haven't had the chance to fix the bug.

adihimself avatar Apr 01 '19 11:04 adihimself

Setting touchEnabled to false worked as a quickfix.

elymentree avatar Apr 01 '19 13:04 elymentree

Thanks @adihimself, this fixed worked like a charm for us as well!

pmsteil avatar Apr 01 '19 18:04 pmsteil

#1240

bharatpatil avatar Apr 02 '19 08:04 bharatpatil

touchEnabled: false, worked for me, but this is a problem that needs a permanent fix, @stevenwanderski

Thank you, @adihimself

BTW, thank you @stevenwanderski for bxslider!

EmilyMarsh-USDA avatar May 01 '19 22:05 EmilyMarsh-USDA

touchEnabled: false is not fixing any more

CreativaDSaravia avatar May 02 '19 06:05 CreativaDSaravia

i've reverted to version 4.2.10

jenbhu avatar May 03 '19 05:05 jenbhu

I followed this thread suggestions and finally worked for me by doing: comment line 1081: slider.viewport.bind('touchstart MSPointerDown pointerdown', onTouchStart);

also onclick event binding at line 1085: slider.viewport.on('click', '.bxslider a', function(e) { if (slider.viewport.hasClass('click-disabled')) { e.preventDefault(); slider.viewport.removeClass('click-disabled'); } });

CreativaDSaravia avatar May 03 '19 13:05 CreativaDSaravia

I fix this problem with comment string http://prntscr.com/nsdqo3 slider.viewport.get(0).setPointerCapture(slider.pointerId);

clientlab-dev avatar May 23 '19 13:05 clientlab-dev

I fix this problem with comment string http://prntscr.com/nsdqo3 slider.viewport.get(0).setPointerCapture(slider.pointerId);

I did this. Links in the slider work now. However on desktop, when clicking and dragging in the slider, upon release, the link you clicked on to drag will open.

JFlotta avatar Jul 31 '19 14:07 JFlotta

Remove or comment this line [ at 1074 ] or change. My problem has solved by this. slider.viewport.bind('touchstart MSPointerDown pointerdown', onTouchStart); Click to see screenshot: 4.1.12 click link problem solvement

ayyilmaz avatar Aug 14 '19 17:08 ayyilmaz

Remove or comment this line [ at 1074 ] or change. My problem has solved by this. slider.viewport.bind('touchstart MSPointerDown pointerdown', onTouchStart); Click to see screenshot: 4.1.12 click link problem solvement

This worked for me. Thanks!

Coop920 avatar Jan 04 '20 15:01 Coop920

To get around the no touch issue on mobile, wrap it in this conditional:

var isTouch =  !!("ontouchstart" in window) || window.navigator.msMaxTouchPoints > 0;
if (isTouch) {
	slider.viewport.bind('touchstart MSPointerDown pointerdown', onTouchStart);
}

xbd63 avatar Jan 24 '20 11:01 xbd63

https://github.com/stevenwanderski/bxslider-4/issues/1246#issuecomment-578089111 @xbd63

Thanks. That works for me.

IamNeo1 avatar Feb 06 '20 13:02 IamNeo1

Just replace following line: if (e.type !== 'touchstart' && e.button !== 0) {

With this code: if ((e.type !== 'touchstart' && e.button !== 0) || e.target.nodeName === 'A') {

danishzahur avatar Oct 21 '21 09:10 danishzahur

Thanks all the "touchEnabled: false" is work for me.

iqbalmbadhan avatar Mar 20 '22 10:03 iqbalmbadhan

Thanks all the "touchEnabled: false" is work for me.

iqbalmbadhan avatar Mar 20 '22 10:03 iqbalmbadhan