bxslider-3 icon indicating copy to clipboard operation
bxslider-3 copied to clipboard

Height fix

Open ptuchster opened this issue 12 years ago • 3 comments

Added fix in case if blocks has different heights

ptuchster avatar Jul 30 '12 12:07 ptuchster

Hi ! I have noticed a problem with this trick : when blocks contain only pictures, these ones are not loaded yet during getHighestChild() exectution. So this one can't calculate outerHeight, returns "undefined" and crashes the getWrapperHeight() function :/

GxiGloN avatar Aug 31 '12 07:08 GxiGloN

Hi! What do you mean: "not loaded yet during getHighestChild() exectution" ??? It's calling on document ready, how they can't be loaded ? O_o Any way, if we assume that it is not loaded on execution of getWrapperHeight() there will be the same effect because this will return undefined for the first children, right? So it's not my bug.

ptuchster avatar Sep 19 '12 07:09 ptuchster

Now fixed bug!

ptuchster avatar Nov 15 '12 11:11 ptuchster