Steven Schlansker

Results 354 comments of Steven Schlansker

Wow, that's quite an issue to track down. Thank you for bringing this to our attention - as soon as a patched antlr is available, we're happy to bring it...

I do find it somewhat ironic / funny that the class is declared to be "immutable" yet has globally shared public mutable fields...

I updated Spring docs. Spring5 will be deleted soon anyway so I didn't change it.

Hi @Randgalt sorry you had troubles with this. I agree it's a bit weird to have two different code paths transactions can start with - but this is historic since...

I asked about this earlier: https://github.com/graalvm/native-build-tools/issues/490

The test failures seem to be intermittent and unrelated to my change...

I added a simple benchmark comparing TreeMap lookups with keys having shared prefixes of various lengths. ``` before Benchmark (bytes) Mode Cnt Score Error Units BytesCompareBenchmark.samePrefixLexico 8 thrpt 20 1.628...

On a temporary branch, I modified the comparator to run both algorithms and `assert` they return the same result. With this, the unit tests continue to pass. That's not necessarily...

The benchmark now has both versions side by side