avr-libc3 icon indicating copy to clipboard operation
avr-libc3 copied to clipboard

Commit ff52582 does not build

Open martin-c opened this issue 4 years ago • 2 comments

I've identified a few issues with the latest commit ff52582 which prevent it from building:

  1. There's a command line in Makefile.in that's indented with 4 spaces instead of a tab which causes an error when make tries to parse the file.

  2. The header file avr/io.h now has a block surrounded by #if !defined(AVR_LIBC_LEGACY_IO) ... #endif. The problem is that this conditional block skips including avr/common.h (and others) when AVR_LIBC_LEGACY_IO is defined. This causes the compiler to eventually generate an error since AVR_STACK_POINTER_REG in libc/stdlib/stdlib_private.h is no longer defined.

  3. Many of the header files in avr/legacyio refer to common headers which were previously just in the avr directory. For example, iom48.h includes avr/iomx8.h. Since iomx8.h has been moved to legacyio directory this and other include directives fail.

martin-c avatar Nov 20 '19 09:11 martin-c

This version is a work in progress, i seriously didn't expect anyone to use it yet. That said, your patches are appreciated. I am currently heavily tied up with work so can't get much time to work on this, but i haven't abandoned it. So if you like to propose patches, i am happy to apply them.

stevenj avatar Feb 10 '20 01:02 stevenj

I suggest to follow a branching model like git-flow, which makes it much easier for people to see what is work in progress, and what is deployable.

burnpanck avatar Apr 26 '20 10:04 burnpanck