Steven Hartland

Results 288 comments of Steven Hartland

Thanks for testing. I have a bug bash branch that I'm working on improving the stability of tests which includes a reworked reaper spawner and while this may not fix...

> See #68593, just parsing the modfile doesn't provide enough information for if a module should be direct or indirect, and the default addition is to mark it as indirect....

FYI I have some code which I believe fixes the behaviour, just need to get a PR created from it.

Thanks for the link, to clarify are users of `modfile` expected to use `SetRequireSeparateIndirect` to add requires instead of `AddRequire` / `AddNewRequire` @matloob?

To confirm my understanding, AddRequire and AddNewRequire should ideally maintain the status? If so this is what exactly https://github.com/golang/mod/pull/21 targets to do. However it does always look to create two...

The problem with that is it means you add a dependency on the `go` binary, the reason for using `modfile` is to avoid that, otherwise you could just exec `go...

Totally agree that `go mod tidy` is still needed, in our use case this is done as a separate step outside of the container that is making the initial changes....

This is fixed by two different pending PR's https://github.com/testcontainers/testcontainers-go/pull/2661 and https://github.com/testcontainers/testcontainers-go/pull/2725

The provider type will auto detect podman if `DOCKER_HOST` is set, does that help?