Sharing link not working

[srothst1]

Hi @stevengoldberg :wave: I just discovered this repository and I absolutely love it. I have been trying to re create the synth sound on Nangs by Tame Impala. I think I am getting close!

The issue that I am facing is that the share UI element is not providing me with a link to my presets. Any suggestions for how to resolve this?

[stevengoldberg]

Hey Sam, I'm glad you're enjoying this project! For context, I wrote this in 2015 when I was looking for a new job and I haven't touched it since then. A lot of the code is outdated by modern web standards. I looked at it for a minute and you're right that the share patch functionality isn't working. When you click the share button, it's supposed to serialize the synth settings into a query string https://github.com/stevengoldberg/juno106/blob/34d1db1f8521a0a99f07d5587af08bcc54b5eaeb/js/views/layout/junoLayout.js#L218 and then when you click the button it's supposed to copy the URL to your clipboard https://github.com/stevengoldberg/juno106/blob/34d1db1f8521a0a99f07d5587af08bcc54b5eaeb/js/views/modal/shareItemView.js#L24. When the app loads it should parse the patch from the URL https://github.com/stevengoldberg/juno106/blob/34d1db1f8521a0a99f07d5587af08bcc54b5eaeb/js/routers/patchRouter.js#L8. I couldn't tell you which part of that is broken — except that the library used for copying to the clipboard is now deprecated, since it seems that functionality is now supported natively by browsers — but if you want to fork it and make it work, that's where I'd look.

On Fri, Sep 30, 2022 at 12:34 PM Sam Rothstein @.***> wrote:

Hi @stevengoldberg https://github.com/stevengoldberg 👋 I just discovered this repository and I absolutely love it. I have been trying to re create the synth sound on Nangs by Tame Impala. I think I am getting close!

[image: Screenshot from 2022-09-30 09-28-20] https://user-images.githubusercontent.com/39531367/193316208-92d8e874-5f9f-488c-82ad-598d4c833834.png

The issue that I am facing is that the share UI element is not providing me with a link to my presets. Any suggestions for how to resolve this?

— Reply to this email directly, view it on GitHub https://github.com/stevengoldberg/juno106/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARAVUHXIZSE3TS5ZI2V7UDWA4JAXANCNFSM6AAAAAAQZ5U474 . You are receiving this because you were mentioned.Message ID: @.***>