OneMore
OneMore copied to clipboard
stevencohn
Please add colorizing support for php
What a great Add-in! Can't live without it. Great job!
CSS, HTML, XML, javascript are there, so very important: PHP is missing.
I tried to add by myself by adding php.png (16x16) and a php.json into Colorizer\Languages, restartet OneNote, but it doers not show up in the UI-list. Needs it to be compiled? Or do I have to de-activate and activate the addin on OneNote first?
Anyway, I started with the csharp.json and replaced the list of keywords. That is the only change I made. It might not be perfect
P.P. I started with the selection "Feature request", but my post did not get this label, and I can't add it later on...
Check the %temp%\OneMore.log file. There may be a syntax error in the json??
Thanks a lot!
I did not know the log file. YES! It worked! It was a missing " in the json. Now I see that my keyword list is missing some expressions, but in general it works! I need to tweak my jason, but i am on my way. I could share it here so that You can add it to the next version.
Is there a file to change the syntax colours for Comments, variables, etc?
There is a Themes folder adjacent to the Languages folder. Hopefully, there are enough classifications of colors in there already; they are all shared amongst the languages so if PHP has something specific, it would be best to create a new classification.
You can share changes here or submit a PR to this repo.
Hey @abtzero! If you have the php config files, feel free to open a pull request. Or attach them here and I'll include them in the next release.
Here we are.
Best regards
Sven Rowoldt
Von: yuganglidemao @.> Gesendet: Montag, 8. April 2024 04:30 An: stevencohn/OneMore @.> Cc: Sven Rowoldt @.>; Mention @.> Betreff: Re: [stevencohn/OneMore] Please add colorizing support for php (Issue #1325)
@abtzero https://github.com/abtzero Can you provide php.json download, thank you!
— Reply to this email directly, view it on GitHub https://github.com/stevencohn/OneMore/issues/1325#issuecomment-2041755152 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZBJ7WKKHZCDCQ27XZACLTY4H6MLAVCNFSM6AAAAABEXVOT4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRG42TKMJVGI . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ACZBJ7SZ5OTSCNWY6WBQ5U3Y4H6MLA5CNFSM6AAAAABEXVOT4OWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTZWK3BA.gif Message ID: @.*** @.***> >
Added a PHP language definition file here. It's not entirely complete but should highlight the important bits. I'd appreciate suggestions to improve its coverage.