Steven Benner

Results 70 comments of Steven Benner

@jasco How big is the change? If it's a significant rewrite of this patch then go ahead and open a new pull request. Might be educational for me to see...

I've had a chance to test this out and do a code review, and I did find one bug. #### Normal ![normal](https://cloud.githubusercontent.com/assets/141884/22406611/b5c74f96-e60a-11e6-8aeb-45644d3c0961.png) #### bodyoffset-rel ![bottom-gap](https://cloud.githubusercontent.com/assets/141884/22406582/3c286cd8-e60a-11e6-8e56-eb300727da8c.png) _Env: Firefox 51.0.1_ Notice that...

Thanks for the updates! The latest version fixed that bug, though I did discover another bug in testing. ### Smart placement broken in relative positioning It looks like the smart...

Could you provide an example for me to look at? An iframe is just a window within a window, so if your iframe contains a document with tooltips then it...

Okay I created a test and can see what is going on. When trying to get the `offset()` of an element inside an iframe the values returned are relative to...

Okay, I see. You're adding the iframe properties to an option when `powerTip()` is run and using that to adjust the position info. That makes sense, but it makes running...

@thomasjoyce Just to let you know what's happening on my end: I haven't had a chance to dig deeper into this yet. This is an edge-case request so it keeps...

Could you go into more detail on this comment: > However, it appears that document.body serves equally well as a references and avoid needing to manipulate DOM. I'm really hesitant...

Could you submit a pull request for the alternate version? This problem is a bug that is likely affecting people right now, so it's higher priority than supporting unexpected body...

Thanks for the pull request! This looks pretty good. But I still have a rather long backlog to go though and push up for the v1.3 release. So let me...