novel icon indicating copy to clipboard operation
novel copied to clipboard

Thinking about adding a dark mode?

Open Azad-Aihub opened this issue 1 year ago • 3 comments

Is it possible to consider adding a dark mode switch, which could be great for writers used to writing in dark mode?

Azad-Aihub avatar Jun 20 '23 04:06 Azad-Aihub

Yeah I tried adding that before, unfortunately we're blocked by Tailwind Typography not supporting dark mode with prose-invert: https://github.com/tailwindlabs/tailwindcss-typography/issues/228

cc: @adamwathan

steven-tey avatar Jun 20 '23 13:06 steven-tey

I've been able to implement dark-mode in tailwind with the typography plugin with just prose dark:prose-invert.

notjustinshaw avatar Jun 21 '23 20:06 notjustinshaw

@notjustinshaw 👀 that's awesome! Feel free to make a PR to add dark mode to Novel! 😄

steven-tey avatar Jun 22 '23 15:06 steven-tey

I could get darkmode to work, I'm using cookies to store current mode

GIF demo

Dhravya avatar Jun 28 '23 21:06 Dhravya

I could get darkmode to work, I'm using cookies to store current mode

GIF demo GIF demo

this dark mode ui looks in consistent , that toggle button size is large , continue writing icon missing etc also y store in cookie ? i think it is better to store the theme state in local storage than cookies

sreehari2003 avatar Jul 04 '23 17:07 sreehari2003

Yeah, I fixed all the issues you mentioned in the above commits already. 😁

Why cookies: it's hard to manage global state in server components, local storage could be done but this was a very straightforward approach, so I went with it

Dhravya avatar Jul 04 '23 17:07 Dhravya

Yeah, I fixed all the issues you mentioned in the above commits already. 😁

Why cookies: it's hard to manage global state in server components, local storage could be done but this was a very straightforward approach, so I went with it

Dhravya avatar Jul 04 '23 17:07 Dhravya

Ne olduğunu anlamayan yine ben

Amsalak avatar Jul 04 '23 18:07 Amsalak

Dark mode is now live!! #80

steven-tey avatar Jul 07 '23 22:07 steven-tey