Steve Mayhew

Results 49 comments of Steve Mayhew

Unless we want to go for renaming `KeyLoadInfo` to `KeyRequestInfo` and moving forward with the `drmKeysRemoved()` update too... I would squash the commits and run the code beautifier on what...

No problem, we both have day jobs too! I’ve assigned some tasks here internally to move our most important pull requests over from ExoPlayer to AndroidX On Tue, Feb 27,...

I'm on vacation next week @icbaker so it will take a bit to get to these changes. Only one I need your input on is best path for the `taskId`

@icbaker I'm curious why `DefaultDrmSession.RequestHandler` was even implemented rather than using the existing `com.google.android.exoplayer2.upstream.Loader`. which does largely the same thing with a richer set of API calls to observe and...

> You can probably hard-update the `DrmSessionEventListener.EventDispatcher.drmKeysLoaded` method to take the new `KeyLoadInfo` type without deprecating the zero-arg overload, since direct usages of that are probably quite rare (custom `DrmSessionManager`...

@icbaker Here's the pull request with first pass: https://github.com/androidx/media/pull/1134 I need to plumb through to `AnalyticsListener` in order for it to be useful, wanted to stop before I got to...

Thanks, that will work for the application... But we have changes to ExoPlayer itself, library/core, hls, extractor, etc. Most are shared as pull requests (or soon to be). Looks like...

Thanks @marcbaechinger I imagine this migration-script is rather unglamorous to maintain ;-). The correct thing to do is migrate in-place. None of the moves conflict with existing ExoPlayer files so...

> Thanks, I can repro now. It's somewhat similar to #8312 and maybe related to #8959. > This is most definitely a duplicate of #8312. This HLS coding is attempting...