Steve Mayhew

Results 49 comments of Steve Mayhew

@tonihei Not sure where this fits in with the plan to eliminate the fact that you cannot discard chunks that have been spliced , https://github.com/google/ExoPlayer/blob/aedde2de396995e4354f3110cc37e86b48525892/library/hls/src/main/java/com/google/android/exoplayer2/source/hls/HlsSampleStreamWrapper.java#L1253 Can I see the internal...

> Thanks for the PR and the well-written problem description! > > We should be able to merge this, but please see my suggestion to make it more targeted and...

> I think we can make this condition more targeted to also work in cases where not both chunks are from a trick-play tracks. Maybe, I added one test case...

> > I'm still not sure I see the use case for ever splicing when switching to/from an iFrame only track... > > I can see this being used when...

Thanks @WontsonWong the latest pull request looks better, it is missing the first frame render so the seek resolution time is perceived to be longer. One more thing to consider,...

@WontsonWong any movement on answering these two questions: 1. Is it possible to turn off the AmLogic auto frame rate up conversion with a property (like `auto-frc`), now or in...

@tonihei and @icbaker See https://github.com/google/ExoPlayer/issues/10445#issuecomment-1208437362 on the bug this fixes. Bottom line, this pull request is not needed. I would encourage simplifying the logic to determine decode only to avoid...

@WontsonWong if you could share more on what this change was from AMLogic: > SEI / AMLogic determined that the issue was specifically happening on during tuning when the 1080...

@tonihei Here's some note and comments from our internal bug with Evolution for this... I believe this issue is: 1. A platform (AmLogic firmware) issue 2. Triggered by 1080p resolution...

> Does it make sense to wait for this investigation? Somewhat, would greatly appreciate any investigation your team can do as well with SEI / AmLogic, as they supply you...