Steve Mao

[nodejs lambda layer] no metrics is exported to cloudwatch logs

4

--- name: Bug report about: Create a report to help us improve title: ''[nodejs lambda layer] no metrics is exported to cloudwatch logs" labels: bug assignees: '' --- **Describe the...

Please try this file https://www.dropbox.com/s/b9u4b431q0rpc4k/test.zip and it will try an error: Fatal error: invalid block type

Should probably warn users in the readme what the consequences of doing this

7

Just my 2c. Your PR is still open and you can't modify it if you remove a fork etc...

Tests?

3

https://github.com/mikedeboer/node-github has really great tests :D

Improvements

6

add some (hopefully) useful comments don't use regex when possible combine some if statements remove unnecessary `isTop` check this PR increases about 15 op/s there is no logic changes

Broken regex implementation

7

do you support this use-case? If the `str` contains more `a` than `b` / there are unmatched pairs, and a and/or b is regex, what's the expected behaviour?

How to aggregate on MaybeFields?

1

After `optionalRestrict`, I get `maybeFieldsR` but then I need to aggregate on it. I cannot figure out how to do that other than converting it to nullable. These work ```haskell...