Steve Loughran

``` ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/TrackingByteBufferPool.java:101: public static class LeakDetectorHeapByteBufferPoolException extends RuntimeException {: Class LeakDetectorHeapByteBufferPoolException should be declared as final. [FinalClass] ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java:643: TrackingByteBufferPool pool = TrackingByteBufferPool.wrap(getPool());:28: 'pool' hides a field. [HiddenField] ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java:679: LOG.info("Slicing is...

.. will look at this asap

latest pr tries to address comments, plus fixing failing test manually run itests for s3, s3 + analytics and abfs

Checkstyle is *mistaken*, there is a subclass `ByteBufferAllocationStacktraceException`.

hasn't adaped to the 11.4 upgrade as it was using avro ser/deser as part of the workflow, and that can't be done with the class restrictions.

## full commit logs of squashed commits --------- PR with the previous patches. This is a WiP but ready for some iniital review; lacks tests & spec. Also, because the...

Quick review of this, especially the factoring out Good: * unified logic in one place Bad * it's still complex * it's not easy for S3A to optimise further Looking...

I have stopped working on this. Feel free to take it up I originally thought "hey, we could just make this public and there'd be a good rename", but as...

closing issue, giving up on this

This PR is in sync with https://github.com/apache/hadoop/pull/6686 ; the dynamic binding classes in here are from that PR (which also copies in the parquet DynMethods classes for consistency everywhere).