Steve Loughran

Results 340 comments of Steve Loughran

OK, I've tried to address the changes as well as merge with master The one thing I'm yet to do is the one by @danielcweeks : have an interface for...

Code wise, no, other than reviews from others about what is the best place for things, such as that awaitFuture stuff or any other suggestions which people who know the...

@Fokko that's japicmp getting its logic wrong because it's a new file; thought I'd edited the build rules so it would ignore that. anyway, need to fix the merge as...

Thanks. I'm away from my laptop until 2024 but really do want to get this in.

...rebased; now got some (brief) time to look at the comments -don't review just yet

let me have another look at your comments and make sure I've answered them all

Update: I've been looking at overlapping ranges. * The base implementation doesn't care. * the specification and contract tests don't say they MUST be separate * I'm now worried that...

quick updatge on this: in https://issues.apache.org/jira/browse/HADOOP-19098 I'm going to declare that overlapping ranges triggers IllegalArgumentException everywhere; to date only s3a threw exceptions. For the parquet PR I will * add...

spark already ships with a a workaround for all of this, primarily so we could avoid having to fix parquet up too. getting something choreographed across spark and parquet would...

I would prefer if Parquet used the same opt(key, value) builder pattern that we use in the new hadoop FS api calls. https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/filesystem/fsdatainputstreambuilder.html This allows for future addition of new...