Steve Lacey

Results 60 comments of Steve Lacey

Similar actions like `setup-node` and `setup-python` have gone with pulling the version from a standalone file, that'd be great to see here rather than parsing out from composer.json which, as...

@nqbao ok to merge?

Implementation works, but obviously lists in the users network tab - which may be a little annoying for debugging, especially when it legitimately throws a 404 and appears in console.....

@nqbao can you take a look over this?

I found an example of this here: http://www.gradgems.com/login_emp.php However, there seems to be a bigger problem that the extension doesn't seem to even finishing running despite having detected a things...

@JeffBeltran I ran into this issue, the reason was because I have a `$visible = [...]` definition in my user model that doesn't include `tokens` so maybe it'd be a...

@phansys this looks good, are you interested in merge rights to the project? I don't have a lot of time for DE right now and it'd be great to have...

My head isn't in the right place to look properly, but where are you trying to put that? Syntax looks weird if that's meant to be CSS – maybe try?...

@bgantz great! Pull request that :smile: bonus points for stripping back the old functionality – I don't see much need to maintain backwards compat with Ghost prior to formal post...

@bgantz it's probably just a case of stripping out [src/assets/js/scripts.js#L39-L50](https://github.com/stevelacey/ghostium/blob/master/src/assets/js/scripts.js#L39-L50)