Steve Kuznetsov

Custom Flag/Arg Parsing Library Fails On Octal-looking Strings

10

Randomly-generated tmpdirs used as outputs for CRD gen can trip up the options parser in this repo: ``` Error: unable to parse option \"output:crd:dir=./tmp.08cAgAZQNm/chart/crds\": [invalid digit '8' in octal literal...

Parsing Resource Version Is Not Allowed

3

### Overview of the Issue The Kubernetes API [explicitly disallows](https://kubernetes.io/docs/reference/using-api/api-concepts/#resource-versions) parsing the `metadata.resourceVersion` field on an object as an integer. This project, however, does so as of this commit: https://github.com/hashicorp/consul-api-gateway/pull/26/commits/cb0486e386552b24f74a457df00680785d75a2b7...

`clonerefs` output is ignored, so tests can run with with incorrect refs

2

We ignore the output of `clonerefs` due to https://github.com/openshift/ci-operator/commit/7ad9489ab5f502d7b40fdd33df6ca508a84f7697 and https://github.com/openshift/ci-operator/commit/9aa7a8a12785307fb33d22920d53fced467187df. That's simply wrong and must be fixed. We should either run `initupload` or write the log and read it...

bug: kcp apiserver does not serve openapi specifications

5

### Describe the bug The `/clusters/foo/openapi` endpoints for kcp apiserver return the kubernetes OpenAPI spec. ### Steps To Reproduce ``` kubectl get --raw /openapi/v2 | grep ClusterWorkspace ``` ### Expected...

Figure Out Correct Way To Separate Codegen Tags and GoDoc

3

For types where these attributes were *also* added to struct tags, having them on separate lines caused an error: ``` 2023/01/11 07:57:40 OpenAPI code generation error: Failed executing generator: some...

Clarify Workspace Privilege Group Behavior

2

I found `system:kcp:workspace:access` but haven't found the admin one, is this comment up to date? _Originally posted by @vincepri in https://github.com/kcp-dev/kcp/pull/2569#discussion_r1064998501_

bug: ddsif manually manages informers

2

### Describe the bug Today, we manually manage the creation and lifecycle of informers in the DDSIF implementation. We've already seen bugs where this is done incorrectly, and we should...

bug: authorization failures don't tell a user what workspace their request was in

3

### Describe the bug Today, our failures look like this: ``` cowboys.wildwest.dev is forbidden: User "kcp-admin" cannot list resource "cowboys" in API group "wildwest.dev" in the namespace "default": workspace access...

bug: default workspace type creates too many objects in etcd on startup

3

### Describe the bug Today, when a user creates a new workspace, they get a `universal` one, and that brings with it nine keys in `etcd`: - /registry/apis.kcp.dev/apibindings/customresources/root:users:zu:yc:kcp-admin/apiresource.kcp.dev-cg5rx - /registry/apis.kcp.dev/apibindings/customresources/root:users:zu:yc:kcp-admin/scheduling.kcp.dev-7uhq2...

feature: clean up the use of fake clients

2

This is not strictly necessary but a very nice to have for #1943 - [x] pkg/admission/namespacelifecycle/admission_test.go: "k8s.io/client-go/kubernetes/fake" @ncdc (https://github.com/kcp-dev/kcp/pull/2162) - [ ] pkg/authorization/workspace_content_authorizer_test.go: kubefake "k8s.io/client-go/kubernetes/fake" - [x] pkg/client/clientset/versioned/fake/clientset_generated.go: fakediscovery "k8s.io/client-go/discovery/fake"...