2.0 Module updates, discussion. Please add feedback/comments!

[stevekane]

Everyone,

It has come to my attention that this module, which I originally authored as an experiment over a year ago, has started to come into some serious use. There are many things that SHOULD be done to get this module up to snuff. Here are the big three that occur to me.

• [x] Update to latest workshopper. The one it currently uses is extremely old and bad
• [ ] Remove Q dependency and replace with native Promise API (shimmed with RSVP perhaps) – #53
• [ ] Update text for problems to be a bit more explanatory to new-comers. In some cases some of the solutions can also be slightly altered to be a bit clearer and efficient. Merged to above which is a rewrite anyway: #53.

I would prefer to do this work in a re-write branch rather than update the master branch as quite a few things need to change here. If you're interested in contributing please let me know in this thread what you're going to work on. This should be relatively easy to accomplish if we all do a little bit.

Thanks for your interest and for using the module. I hope it was helpful.

Steve

[ExploreMqt]

I'm in. I'd like to start with the third item, but I will pitch in on the others as needed.

[ExploreMqt]

Alright, I think I understand mostly what to do for #1. Do we want the same lessons for after porting to the native promise api?

[TimothyGu]

@ExploreMqt I actually just finished the entire tutorial without Q at all. Here are some remarks on converting the tutorial to Promise:.

1. using_qfcall would need to be removed.
2. The last three tutorials would need to be converted to some module easier to be denodeified like request.

I've gitted my solutions here: https://github.com/TimothyGu/promise-it-wont-hurt-promise. HTH.

Also, I think it would be better if we do the three things in different steps. For example,

;(new Promise(fixDocs))
  .then(updateWorkshopper)
  .then(usePromise)

[TimothyGu]

OK I just submitted #47 and #48 which hopefully will make this tutorial a little bit more polished.

@stevekane if you are not interested in this module anymore or don't have enough time you could consider adding me as a contributor to this repo. Feel free to check out my GH profile if needed.

[bajtos]

1. Update to latest workshopper. The one it currently uses is extremely old and bad
2. Remove Q dependency and replace with native Promise API (shimmed with RSVP perhaps)
3. Update text for problems to be a bit more explanatory to new-comers. In some cases some of the solutions can also be slightly altered to be a bit clearer and efficient.

:+1: :heavy_multiplication_x: :100:

My main interest is in item 2) - rework the adventure to teach the ES6 syntax (API). Unfortunately I don't know when I'll have enough time to contribute this change :( I would like to submit a fix until the International Day of NodeSchool, but can't promise it.

[martinheidegger]

There is a PR for the latest workshopper update by @tdd https://github.com/stevekane/promise-it-wont-hurt/pull/40 Generally I would see need for someone to process the pull requests, most of them should be done quickly. I could spend a little of my time to go through it. At learnyounode @rvaggs adds developers fast to the project to speed up the process and delegate responsibility, a good way to go by it if you ask me, also it would be good if another person would be added as owner to the module in npm so publishes will go through. @TimothyGu seems to be eager for it?!

[TimothyGu]

@martinheidegger Yes I do volunteer.

[stevekane]

Apologies all I am going to review this tomorrow during the day (central time america) and I will add some contributors (as I should have done long ago). Thanks for keeping on me about this and doing great work.

[tdd]

By the way, @stevekane and I had briefly talked through e-mail about my taking over this repo's maintenance, and I'm all for it, but that discussion died out a couple weeks back. Eager to resume it.

[stevekane]

Alright all I don't want to overthink this or cause anyone undue annoyance. Here is my plan. I'm going to add @TimothyGu and @tdd as maintainers of this project and allow them to use their own discretion and collaboration to move this project forward. I am proud to have originally authored this module but my interests have moved significantly since that time (I now focus on webgl and high performance javascript) and I'd like to remove myself from the oversight of this module and allow the community to take control.

If anyone else would like to be added to the project, they should send email to either of these two maintainers and I'm sure something can be worked out.

Steve

[tdd]

Hey Steve, thanks for the vote of confidence!

@TimothyGu OK with my merging #40? I vouch for it!

[TimothyGu]

@stevekane Thank you so much!

@tdd I'll take a look at it ASAP, but I have some more server benchmarks to run atm. Note that I of course can't review the French content ;)

[tdd]

@TimothyGu that's alright: the French L10n was already reviewed. I'm more asking about the code itself, as this upgraded to workshopper's latest infra.

[TimothyGu]

Workshopper deps updated in #40.

[tdd]

Hey @TimothyGu, @stevekane

So I'd love to see FR L10n in a published version… Things are moving forward again, but only Steven can publish on npm. Can we agree on publishing 0.2.0 or 1.0.0 based on current master?

[TimothyGu]

@tdd @stevekane, it is totally OK with me, and I think it is a good time for a release. I'd call it 0.2.0, and the switch from Q would warrant a new major release.

[bajtos]

@stevekane would you mind adding @TimothyGu and @tdd as package owners on npm, so that they can publish new versions too?

[tdd]

I'm concerned 0.2.0 sounds pretty low, but I don't like skipping numbers in a given sequence, so 0.2.0 it is. Moving to ES6 Promises API (either native or shimmed) def warrants a nice 1.0.0 :smile:

Christophe Porteneuve [email protected]

[TimothyGu]

@stevekane Ping. Do you have any plans on giving us the npm ownership?

[TimothyGu]

@stevekane ping × 2

[StevenACoffman]

These are the remaining steps:

1. @stevekane adds the NPM username of @TimothyGu (need to npm adduser timothygu).
2. @stevekane adds @TimothyGu as owner of the promise-it-wont-hurt package (npm owner add timothygu).
3. @TimothyGu publishes the next version of promise-it-wont-hurt on NPM (npm publish . in root dir).

Thanks for an awesome workshop @stevekane. I would really appreciate it if you could help move this forward.

[StevenACoffman]

With node 4.0 out (including native promises), I'd really like to see this move forward again. I've pinged @stevekane on twitter, and he seems receptive, so hopefully that will happen soon.

[stevekane]

This is FINALLY done. Sorry for the extreme delay. No reasonable excuse just the normal ebb and flow of life took me elsewhere.

[TimothyGu]

Hi all,

Just wanted to let you guys know that I have been rewriting the entire workshop for the past few days, converting solutions to ES2015 promises, adding stricter tests, and adding new lessons that I feel should be necessary in the first place. My estimate is that I am almost halfway through the entire process, but this might change if I decide to add more lessons.

French translation is now out-of-date from all the changes I've made recently. @tdd seems to be quite busy right now so if somebody wants to jump in you would be more than welcome. I've also started a Spanish translation but since my third-year Spanish is quite poor help would be appreciated also.

I have also published a new version with all the fixes in master for the past few years.

The legacy tree is now branched out into v0, which will be maintenance only. All new work will be going into master (originally the no-q branch) only.

Thank you for all your recommendations, advices, and support. Feel free to help review & translate!

Timothy

[tdd]

Hey Tim,

Gratz on being steadfast with this work. I haven't looked into the ES2015 rewrite, but I trust this works on recent Nodes without the need for Babel, just perhaps the harmony flags?  It would be great to reduce the requirements surface area as much as possible so the trainees can focus on "just promises", you know.

I'll try and make time for updating the translations before the month is over, as my next NodeSchool Paris is on Feb 6, my next Node training class is on Feb 2, and I'd love for a finalized package to be available by then :-)

On Tue, Jan 19, 2016, at 05:03, Timothy Gu wrote:

Hi all,

Just wanted to let you guys know that I have been rewriting the entire workshop for the past few days, converting solutions to ES2015 promises, adding stricter tests, and adding new lessons that I feel should be necessary in the first place. My estimate is that I am almost halfway through the entire process, but this might change if I decide to add more lessons.

French translation is now out-of-date from all the changes I've made recently. @tdd[1] seems to be quite busy right now so if somebody wants to jump in you would be more than welcome. I've also started a Spanish translation but since my third-year Spanish is quite poor help would be appreciated also.

I have also published a new version with all the fixes in master for the past few years.

The legacy tree is now branched out into v0, which will be maintenance only. All new work will be going into master (originally the no-q branch) only.

Thank you for all your recommendations, advices, and support. Feel free to help review & translate!

Timothy

— Reply to this email directly or view it on GitHub[2].

Christophe Porteneuve [email protected]

Links:

1. https://github.com/tdd
2. https://github.com/stevekane/promise-it-wont-hurt/issues/46#issuecomment-172731538

[TimothyGu]

By ES2015, I meant only ES2015 promises :)

[tdd]

Hey!

@TimothyGu FYI, I'm re-L10n'ing the whole thing to FR. Should be in a PR within 24 hours. I see a couple things in the original EN text that make me tick, but we'll talk about that later.

More to the point, verification of "shortcuts" breaks. Doesn't properly detect catch usage (of its own solution!). I use Node 4.2.6 on OSX through nvm.

[TimothyGu]

@tdd should be fixed in 7b2dcac