unifi-linux-utils
unifi-linux-utils copied to clipboard
stevejenkins
update unifi_ssl_import.sh
did add :
Uncomment following three lines for Unifi Dream Machine CloudKey
UNIFI_DIR=/mnt/data/unifi JAVA_DIR=/mnt/data/unifi KEYSTORE=${JAVA_DIR}/data/keystore
This is wrong. In my opinion, that change is for the user to use. It does not belong in a utility meant for a variety of distros.
No its where unifi controller is installed default on the udm itself.
ons. 15. jan. 2020, 00:50 skrev Johnny A. Solbu [email protected]:
This is wrong. In my opinion, that change is for the user to use. It does not belong in a utility meant for a variety of distros.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stevejenkins/unifi-linux-utils/pull/42?email_source=notifications&email_token=ACJMSD76VVUTJRLAE4ZBFYDQ5ZFV3A5CNFSM4KG3CJKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI6RNXY#issuecomment-574428895, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJMSDZG3FLFSZ7LF7WJBBTQ5ZFV3ANCNFSM4KG3CJKA .
The point is that this script is intended to be used anywhere the unifi controller is installed. I use it on ubuntu, someone else might use it on centos, and others are using it on the cloud key and UDM. It comes with configuration lines for all of those scenarios. All you have to do is comment out the ones for centos and uncomment the cloud key lines.
Whatever your scenario is, you'll need to do some amount of configuration to get this working, it's not something you can just drop in. The hostname also needs to be changed, and if using lets encrypt you'll need to install certbot and change LE_MODE to yes. If you're using normal certificates you need to tell it where those certs are so it can import them. Determining what platform you're on and using the config lines for that platform is probably the easiest part.
Edit: I see the UDM install location is different from the cloud key. It could be added as an option, but it shouldn't be the default since there are so few of them out there.
Skynett81,
If the Unifi Dream Machine does indeed locate the files differently (I don't know as I don't have one), the your proposed changes are valid, but should be commented out (i.e. preceded by "# ") to be consistent.
Regards and thanks Andy
