wp-enforcer icon indicating copy to clipboard operation
wp-enforcer copied to clipboard

Feature: Allow define where the actuall vendor folder is

Open killua99 opened this issue 6 years ago • 12 comments

Some times we have our vendor folder in a bellow level where the .git folder is. With this case we can't call ./vendor/bin/phpcs

We could have it in ./web/vendor/bin/phpcs

With this patch you can do it.

killua99 avatar Aug 09 '17 08:08 killua99

Also I added the option to identify a global installation.

I update the README file with the information about how to use it.

killua99 avatar Aug 25 '17 08:08 killua99

Luigi,

Thanks for the PR, and my apologies for the radio silence. Hoping to be able to look at this shortly!

stevegrunwell avatar Sep 18 '17 15:09 stevegrunwell

Perhaps it will require a few minor tweaks. But please do a quick look of the README file and then try it out.

killua99 avatar Oct 04 '17 07:10 killua99

@stevegrunwell any change you might take a peek at this MR? I would be really useful for us :)

richardsweeney avatar Jan 04 '18 10:01 richardsweeney

@richardsweeney My apologies, I've been swamped with work as of late. Will try to look as soon as I can get myself in a good shell scripting headspace :)

stevegrunwell avatar Jan 11 '18 16:01 stevegrunwell

@johnpbloch thanks for taking a look and the great notes! Maybe I should have had you look this over when I first wrote the package ;)

@killua99, if you're still interested, I'm on board with merging once you address those three comments from @johnpbloch, and sorry again that this has taken forever to get around to.

stevegrunwell avatar Jan 31 '18 14:01 stevegrunwell

Yes I am available to do it, just give me some time, I swear it won't take long 🤣😅

killua99 avatar Jan 31 '18 15:01 killua99

One thing I'll never do is rush people on open-source work. Something about a pot and kettle... 😉

stevegrunwell avatar Jan 31 '18 15:01 stevegrunwell

I hope the response on comment made more clear why that code is there, and how does it work. Also I tried to correct some typo error that, as a non native english speaker I make.

killua99 avatar Feb 01 '18 09:02 killua99

What else would I need to get this merge ?

killua99 avatar Dec 17 '18 08:12 killua99

Day 44532,

They still haven't notice me

killua99 avatar Jun 24 '19 13:06 killua99

@stevegrunwell Let's make this happen :D I'm stoked about these changes

jonathan-dejong avatar Jun 25 '19 06:06 jonathan-dejong