schemify icon indicating copy to clipboard operation
schemify copied to clipboard

Published 20 hours ago • verified publisher icon stevegrunwell

Adding a basic cache-flushing mechanism

Open nicholasio opened this issue 6 years ago • 3 comments

Introduces a basic cache flushing mechanism. #4.

nicholasio avatar Oct 02 '17 15:10 nicholasio

@stevegrunwell I pushed some changes to address your feedback! Thanks for you time looking into this.

By adding filtering on Thing::build() you mean moving the cache purging logic to cache.php by hooking into those filters/actions? If so that makes sense to me, I only kept the logic there because there was already some caching logic there. Let me know what you think.

nicholasio avatar Oct 27 '17 19:10 nicholasio

Merging the latest changes here, I'll take another pass and recreate the tests.

@stevegrunwell are you still open to merge this PR?

nicholasio avatar Jan 30 '18 02:01 nicholasio

@nicholasio Definitely still open, my time on Schemify has been really scattered. Hoping to be able to get back to this towards the end of this week :)

stevegrunwell avatar Jan 30 '18 20:01 stevegrunwell