ProxyApi icon indicating copy to clipboard operation
ProxyApi copied to clipboard

Fix for JS Syntax Errors

Open marlon-tucker opened this issue 11 years ago • 3 comments

Hello,

The T4 template used to append commas (',') in the two foreach loops regardless if the current element was the last element in the sequence. This is invalid syntax for JSON style objects. I switched the foreach loops to for loops and put a condition before writing the commas out.

It does seem most browsers are clever enough to ignore this sort of syntax error, but I have the JavaScript Parser VS plugin to aid web dev, and it wasn't happy with the generated inteliisense files.

I also made the template generate better formatted js, but unfortunately this has caused the T4 template to be harder to read - it seems white space before conditional T4 blocks is included in the output unfortunately

marlon-tucker avatar Jun 19 '13 12:06 marlon-tucker

Hi @marlon-tucker,

I agree with the removal of commas (I'll try to get that merged in) but personally I think I would prefer readability in the code I am working on rather than in the generated code.

stevegreatrex avatar Aug 08 '13 10:08 stevegreatrex

yep that's fair enough, cheers for the reply.

I am having issues with the MVC project I'm using having multiple 'areas' within it, are you aware of any issues with areas or should I submit a bug ticket?

The namespaces aren't resolving correctly to the correct URLs.

marlon-tucker avatar Aug 08 '13 12:08 marlon-tucker

I haven't tested it with multiple areas so create an issue and .I'll look at it when I get a chance.

stevegreatrex avatar Aug 08 '13 12:08 stevegreatrex