HTML5accessibility icon indicating copy to clipboard operation
HTML5accessibility copied to clipboard

@placeholder no longer a candidate for acc description

Open jasonkiss opened this issue 9 years ago • 7 comments

Update the placeholder attribute test page to reflect that placeholder no longer participates in the accessible description computation as outlined in the HTML-AAM.

jasonkiss avatar Dec 22 '16 00:12 jasonkiss

@stevefaulkner It's challenging to update this since it requires a patch to both the website and the test files which are in another repository. What to you recommend? Updating the results here and filing a new issue to the TPG repo?

As for this repo, the site fix seems to be: mark Safari as passing and mark Edge as failing. But I'd prefer to avoid that political pitfall unless @dstorey gives his blessing on the Edge edit. Otherwise, I'll just mark Safari as passing.

cookiecrook avatar Jan 23 '18 03:01 cookiecrook

#72 Updates Safari results

cookiecrook avatar Jan 23 '18 03:01 cookiecrook

@jasonkiss @stevefaulkner this was correct but looks like the spec changed after we implemented :(

Is placeholder just removed from accDesc or also accName too? (presumably just the former)

If the former the fix is either to remove ph-002 and ph-003 tests or to leave them to explicitly test against the previously correct behavior and change the test desc to say placeholder shouldn't be the accDesc.

dstorey avatar Feb 05 '18 22:02 dstorey

Regarding Edge implementation, if this is the new behaviour I'll work with the team to get Edge behaviour updated for an upcoming release.

dstorey avatar Feb 05 '18 22:02 dstorey

Update: Regarding Edge support, we're updating to remove placeholder from the name/description mapping to reflect the latest version of the spec.

@stevefaulkner how would you like the test to change? I can spare some cycles to update it if you like. My initial thought is to just remove the name/description requirement in the placeholder test, as it is consistent with the rest of the test where only features that contribute to name/desc algorithm include that test. The test already includes the requirement to map placeholder/aria-placeholder correctly.

dstorey avatar Feb 16 '18 22:02 dstorey

@dstorey yeah if you can update would be great! the change you suggest sounds good.

stevefaulkner avatar Feb 23 '18 14:02 stevefaulkner

Please see PR at https://github.com/ThePacielloGroup/AT-browser-tests/pull/62

dstorey avatar Mar 10 '18 00:03 dstorey