showcode icon indicating copy to clipboard operation
showcode copied to clipboard

feat: add possibility to write the filename per editor

Open dimaslz opened this issue 2 years ago • 8 comments

Hello @stevebauman here the PR about my suggestion https://github.com/stevebauman/showcode/issues/29

Take a look at how it looks:

With one file: Screenshot 2022-01-01 at 14 01 43

With more than one file Screenshot 2022-01-01 at 14 00 48 Screenshot 2022-01-01 at 14 00 39

Let me know if I can improve something in code or UI.

UPDATE: update with new UI and rebase with master

dimaslz avatar Nov 23 '21 21:11 dimaslz

✔️ Deploy Preview for festive-hermann-8f687a ready!

🔨 Explore the source changes: 2c224462a7a8a48302310c0201daccedfc634be8

🔍 Inspect the deploy log: https://app.netlify.com/sites/festive-hermann-8f687a/deploys/61e9d4d103cded0007de995e

😎 Browse the preview: https://deploy-preview-52--festive-hermann-8f687a.netlify.app

netlify[bot] avatar Nov 23 '21 21:11 netlify[bot]

This is so cool @dimaslz! Nice work! 🎉

I'll review this early tomorrow, but I love this idea and the look of it 👍

stevebauman avatar Nov 24 '21 02:11 stevebauman

Hmm -- when I add a new editor and start typing into the file name field, nothing appears on the preview window until I refresh?

stevebauman avatar Nov 24 '21 13:11 stevebauman

Hello, @stevebauman I rebased and updated the PR, I think now is fixed. I missed the initial value.

dimaslz avatar Nov 24 '21 20:11 dimaslz

Thanks @dimaslz! Could we have these inputs only show when we have 2 or more editors? I don’t think we should have them displayed when there’s only one editor (we can use the title field for that).

Let me know your thoughts!

stevebauman avatar Nov 26 '21 00:11 stevebauman

Thanks @dimaslz! Could we have these inputs only show when we have 2 or more editors? I don’t think we should have them displayed when there’s only one editor (we can use the title field for that).

Let me know your thoughts!

Mmmm... I think make sense. I will take a look.

dimaslz avatar Nov 26 '21 22:11 dimaslz

Hello @stevebauman, sorry for my delay.

Take a look ;)

dimaslz avatar Jan 01 '22 14:01 dimaslz

@dimaslz @stevebauman Any updates on this feature?

bdsoha avatar Dec 16 '22 03:12 bdsoha